ext/pgsql: Use zval_try_get_string() instead of converting zval #15265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
reviewed
Aug 7, 2024
| convert_to_string(parameter); | ||
| S->param_values[param->paramno] = Z_STRVAL_P(parameter); | ||
| S->param_lengths[param->paramno] = Z_STRLEN_P(parameter); | ||
| zend_string *param_value = zval_try_get_string(parameter); |
There was a problem hiding this comment.
seemed a good idea, but you need to release it at some point. would need some bookeeping.
There was a problem hiding this comment.
I haven't thought deeply about it yet, as I haven't really figured out how this works, and it seems to delegate to PDO... which might be an issue.
But I discovered we have a try_convert_to_string() function which might be better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.