WIP: add new test to uncoverage SQLite3 method.

[marcosptf]

new test to sqlite3 module.

[krakjoe]

I'm not sure how this test works.

[marcosptf]

Hello @krakjoe how are you?
fine?

please, give me some example and ill fix this code!
thanks for your comment!

[marcosptf]

hello @krakjoe how are you?

i'll try explain what i want to do:
1)these lines, a want the this function return a boolean becouse is a valid param:
var_dump($db->busyTimeout(0));
var_dump($db->busyTimeout(1000));

2)these lines, a want this function return anything, false, exception or some error, because the param is invalid, but the same time this function return a boolean true.
var_dump($db->busyTimeout(null));
var_dump($db->busyTimeout(-1000));

Do you know if is a correct ?

Thanks!!!

[KalleZ]

@krakjoe its simply for coverage, the return value will in 99% cases always be true, the only way we can trigger a warning is if libsqlite3 was compiled with their API Armor (which we do not do for the bundled libsqlite3), I did a commit related to this PR as I was reading through it but forgot to reply:
http://git.php.net/?p=php-src.git;a=commitdiff;h=6ca38e8cf8a4fa4b11a4a92131ef8f476659b7a9;hp=b4a6408029b6202af8bc4df2e0116f17b1067e88

@marcosptf The test seems good enough to me

[marcosptf]

@krakjoe @KalleZ
okey thanks for explain to us!!!

[krakjoe]

@KalleZ sorry but adding tests that are going to intermittently fail (even in a tiny minority of cases) doesn't seem sensible to me, so I won't commit this.

Can't a skipif be added to detect the case where it may raise a warning and skip, if that makes sense ?

[marcosptf]

Hello @krakjoe how are you?
fine?

this --skipif-- tag is used by:
https://github.com/php/php-src/blob/master/ext/sqlite3/tests/sqlite3_03_insert.phpt#L3
https://github.com/php/php-src/blob/master/ext/sqlite3/tests/sqlite3_02_create.phpt#L3
https://github.com/php/php-src/blob/master/ext/sqlite3/tests/sqlite3_01_open-mb.phpt#L3

and many others scripts.

please, give me some example and ill fix this code!
thanks for your comment!

have a nice day!

[krakjoe]

I believe we have new abilities in this area, XFAILIF, please research it and update test accordingly.

[marcosptf]

thanks, fixing....

[krakjoe]

Merged 6347e25

Thanks.