add new test to uncoverage standard dns function. #1806
Conversation
was created a new function to dns standard module;
|
Needs skipif for online tests. |
|
Hello @krakjoe how are you? thanks for your comment! |
ext/standard/tests/checkdnsrr.phpt
Outdated
| marcosptf - <marcosptf@yahoo.com.br> - @phpsp - sao paulo - br | ||
| --SKIPIF-- | ||
| <?php | ||
| if (phpversion() < "5.3.0") { |
There was a problem hiding this comment.
Same as my comment to the hash tests, no version check needed here
ext/standard/tests/checkdnsrr.phpt
Outdated
| <?php | ||
| if (phpversion() < "5.3.0") { | ||
| die('SKIP php version so lower.'); | ||
| } |
There was a problem hiding this comment.
Like @krakjoe said, needs to test for online tests here
ext/standard/tests/checkdnsrr.phpt
Outdated
| ?> | ||
| --FILE-- | ||
| <?php | ||
| $serverUrl = "yahoo.com"; |
There was a problem hiding this comment.
Could you please use php.net here? Then we don't rely on external services for which we do not have any control over
ext/standard/tests/checkdnsrr.phpt
Outdated
| --EXPECTF-- | ||
| Warning: checkdnsrr() expects at least %d parameter, %i given in %s on line %d | ||
| NULL | ||
| bool(%s) |
There was a problem hiding this comment.
Are these values not reliable for bugs.php.net? If so then a baked in bool(true) or bool(false) should be fine? (I'm not entirely into how this function works entirely)
There was a problem hiding this comment.
okey
i'll test it before in my computer and answer to you!
Thanks!!!
There was a problem hiding this comment.
Thank you, once you have done that then the test should be good enough to committed, thanks for your work!
There was a problem hiding this comment.
@KalleZ
Thank you about the explanation !!!
ext/standard/tests/checkdnsrr.phpt
Outdated
| bool checkdnsrr ( string $host [, string $type = "MX" ] ); | ||
| --CREDITS-- | ||
| marcosptf - <marcosptf@yahoo.com.br> - @phpsp - sao paulo - br | ||
| --FILE-- |
There was a problem hiding this comment.
This needs a SKIPIF section for online tests like @krakjoe mentioned:
if (getenv("SKIP_ONLINE_TESTS")) { die('skip: online test'); }
|
Again, |
|
@krakjoe |
|
Hi @krakjoe Thanks!!!! |
|
Merged c7f45aa Thanks. |
was created a new function to dns standard module;