test to function setrawcookie(); #1813
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was added a new test coverage to function standard module network;
|
Hi Marco! Thanks for the PR, but in my opinion this test is not very useful, because it doesn't check whether the Set-Cookie headers are actually set. It seems to me that it would be better to do the test like setcookie.phpt. |
|
Hi @cmb69 ! thanks for your comment! ill revise my code like you said and update this commit! |
|
Since we have waited 6 months this single test to be updated, and since the author seems to have abandoned working on it, I'm closing this PR. Please take this action as encouragement to open a more suitable PR, as directed by other contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was added a new test coverage to function standard module network;