-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PCRE2 support #2857
Closed
Closed
PCRE2 support #2857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weltling
force-pushed
the
pcre2
branch
4 times, most recently
from
October 24, 2017 19:57
97eef17
to
66b8b81
Compare
weltling
force-pushed
the
pcre2
branch
8 times, most recently
from
November 2, 2017 18:29
8de4ca9
to
b1d09e9
Compare
weltling
force-pushed
the
pcre2
branch
3 times, most recently
from
November 8, 2017 14:42
87bc915
to
8def498
Compare
Don't refetch contexts in the loop More datatype fixes
Though, the 'X' modifier is the default behavior in PCRE2. We should make it default in PHP one day.
Merged with master as a5bc5ae. Thanks. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to switch to PCRE2 in the core. Things done so far
See http://pcre.org/current/doc/html/pcre2api.html for the PCRE2 API details.
The RFC for this change https://wiki.php.net/rfc/pcre2-migration.
Thanks.