[7.2] Revert BC break caused by fixing bug #74035 #2893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9ffc6ca.
Majkl578
changed the title
sgolemon
requested changes
Nov 6, 2017
| ZEND_BEGIN_ARG_INFO_EX(arginfo_reflection_class_newInstance, 0, 0, 0) | ||
| ZEND_ARG_VARIADIC_INFO(0, args) | ||
| ZEND_BEGIN_ARG_INFO(arginfo_reflection_class_newInstance, 0) | ||
| ZEND_ARG_INFO(0, args) |
There was a problem hiding this comment.
This doesn't seem to be correct. On line 4759 below, we accept the args to newInstance as a variadic set, not as a single $args array.
|
After discussion with @nikic I'm merging this for inclusion in RC6. |
|
Comment on behalf of pollita at php.net: Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts BC break in PHP 7.2 introduced in PR #2363, reverts commit 9ffc6ca
Fixes bug #74292
Relates to #74035 (which PR #2363 aimed to fix)
Unbreaks doctrine/common#822
This was already reverted in 7.0 and 7.1 back in february in eb1373e by @nikic, but kept in master as a valid fix (for 8.0).
NEWS don't seem to contain any mention thus no changes there.
This intentionally targets PHP-7.2 branch where BC break is introduced. It is fine to be kept in master (and though repeat this ceremony for 7.3 😆).