Fix accessibility checks for dynamic properties #3626
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A dynamic property may be shadowed by a private/protected property. Make sure we check property accessibility for non-indirect properties as well.
nikic
force-pushed
the
dynamic-prop-access-check
branch
from
d9dd4d9
to
d556961
Compare
|
@dstogov Can you please check this? I don't like that we have to check access for dynamic properties, but I don't really see a better way. |
|
I think, this is OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A dynamic property may be shadowed by a private/protected property. Make sure we check property accessibility for non-indirect properties as well. Previously mentioned in #3573 (comment).
There is one more caveat here, in that access checks for the dynamic property case should also treat mangled names as accessible (per existing behavior). This is why I added the
is_dynamicflag tocheck_property_access.