Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #77642: typo "incompatibe" in Zend/zend_compile.c #3866

Closed
wants to merge 1 commit into from

Conversation

divinity76
Copy link
Contributor

the word "incompatible" was accidentally written as "incompatibe"

guilty commit: 7e597f4

the word "incompatible" was accidentally written as "incompatibe"

guilty commit: 7e597f4
Copy link
Contributor

@carusogabriel carusogabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip: for commits that only change comments, you can append [skip ci] to the commit message to avoid unnecessaries CI runs :)

@cmb69
Copy link
Member

cmb69 commented Feb 20, 2019

Thanks! Applied as 876369b.

I don't see the need to file such minor typos as bug report, though. A PR is fully sufficient.

@cmb69 cmb69 closed this Feb 20, 2019
@divinity76
Copy link
Contributor Author

divinity76 commented Feb 20, 2019

@cmb69 i guessed so, but i also read this :p
image

  • so i made one anyway just to be on the safe side, guess i won't do it next time :p (if there is a next time)

@cmb69
Copy link
Member

cmb69 commented Feb 20, 2019

@divinity76 If something is a real bug, usually it get's fixed in the oldest still actively supported PHP version (and all newer versions as well). These issues should indeed have a ticket in the bug tracker, so we can easily refer to these from NEWS (aka. Changelog). A typo in a comment or some other descriptive text is not really regarded as bug (usually, no PHP user will notice, or really care about that), and so will be fixed only in master (or, as current exception, in PHP-7.4 as well), does not need a NEWS entry, and accordingly no separate ticket. Of course, we're nonetheless happy to get PR's to fix these typos – now and in the future. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants