Deprecate old ReflectionParameter type declaration APIs #5209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
force-pushed
the
deprecate-old-reflection-type
branch
from
83fd83c
to
06f64ef
Compare
khs1994
added a commit
to pcit-ce/pcit
that referenced
this pull request
May 19, 2020
Signed-off-by: Kang Huaishuai <khs1994@khs1994.com>
khs1994
added a commit
to pcit-ce/pcit
that referenced
this pull request
May 19, 2020
Signed-off-by: Kang Huaishuai <khs1994@khs1994.com>
ciaranmcnulty
added a commit
to ciaranmcnulty/Behat
that referenced
this pull request
Jun 25, 2020
This is deprecated in PHP 8 (php/php-src#5209). Because we require PHP >=7.1 we can rely on getType returning a ReflectionNamedType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates:
ReflectionParameter::isArray()ReflectionParameter::isCallable()ReflectionParameter::getClass()These APIs have been superseded by
ReflectionParameter::getType()since PHP 7.0. Types introduced since that time are not available through the old APIs, and their behavior is getting increasingly confusing. This is how they interact with PHP 8 union types:isArray()will return true if the type isarrayor?array, but not any other union typeisCallable().getClass()will return a class forT|intetc, as long as the union only contains a single type.T1|T2will return null.This behavior is not particularly reasonable or useful, and will get more confusing as new type system extensions are added.