Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear error flag instead of toggling it #6190

Closed
wants to merge 1 commit into from
Closed

Clear error flag instead of toggling it #6190

wants to merge 1 commit into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Sep 23, 2020

The toggling of the REPORT_ERRORS looks fishy, and likely was
intented as clearing.

Let's see the CI results.

@cmb69
Clear error flag instead of toggling it
53243f3 
The toggling of the `REPORT_ERRORS` looks fishy, and likely was
intented as clearing.
@cmb69 cmb69 marked this pull request as ready for review September 23, 2020 13:37
@cmb69
Copy link
Member Author

cmb69 commented Sep 23, 2020

CI is green. Any thoughts about this change?

@php-pulls php-pulls closed this in ffa5716 Sep 23, 2020
@cmb69 cmb69 deleted the cmb/clear-report-errors branch September 23, 2020 21:27
@GromNaN GromNaN mentioned this pull request Dec 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmb69 @nikic