Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate AVIF support from libgd #7026

Closed
wants to merge 38 commits into from
Closed

Propagate AVIF support from libgd #7026

wants to merge 38 commits into from

Commits on May 24, 2021

  1. Initial commit before rebase

    @morsssss
    morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    592ac3a View commit details
    Browse the repository at this point in the history

  2. Incremental commit

    @morsssss
    morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    86a5eb0 View commit details
    Browse the repository at this point in the history

  3. Incremental commit

    @morsssss
    morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    f1b3dd1 View commit details
    Browse the repository at this point in the history

  4. Include logic to extract speed param in _php_image_output_ctx()

    @morsssss
    morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    acc40b9 View commit details
    Browse the repository at this point in the history

  5. Change gd includes to quotes instead of angle brackets 

    To avoid possible collision with the original libgd header files, which may be installed somewhere common like /usr/local/include
    @morsssss
    morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    e613ec3 View commit details
    Browse the repository at this point in the history

  6. Change one avifFree() to gdFree()

    @morsssss
    morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    1fad3c4 View commit details
    Browse the repository at this point in the history

  7. Fix includes

    @morsssss
    morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    a077c1a View commit details
    Browse the repository at this point in the history

  8. Add test script and test image

    @morsssss
    morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    4c8790f View commit details
    Browse the repository at this point in the history

  9. Use new --EXTENSIONS-- to ensure gd is available

    @morsssss
    morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    cf9696b View commit details
    Browse the repository at this point in the history

  10. Fix IMAGETYPE_AVIF support 

    We fix an accidental fall through, and the order of enum values (COUNT
has to be last).  We also fix the respective test case.
    @cmb69 @morsssss
    cmb69 authored and morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    d698aad View commit details
    Browse the repository at this point in the history

  11. Fix failing test case

    @cmb69 @morsssss
    cmb69 authored and morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    14d6d2f View commit details
    Browse the repository at this point in the history

  12. Add AVIF support for bundled GD on Windows

    @cmb69 @morsssss
    cmb69 authored and morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    b9d8de8 View commit details
    Browse the repository at this point in the history

  13. Build GD with libavif on AppVeyor 

    This is only needed as long as libavif is not part of the official
dependencies.  This commit should be reverted before the PR is merged.
    @cmb69 @morsssss
    cmb69 authored and morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    9aa1b36 View commit details
    Browse the repository at this point in the history

  14. Initial commit before rebase

    @morsssss
    morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    0585c08 View commit details
    Browse the repository at this point in the history

  15. Incremental commit

    @morsssss
    morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    5a73a40 View commit details
    Browse the repository at this point in the history

  16. Incremental commit

    @morsssss
    morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    a1cb830 View commit details
    Browse the repository at this point in the history

  17. Change gd includes to quotes instead of angle brackets 

    To avoid possible collision with the original libgd header files, which may be installed somewhere common like /usr/local/include
    @morsssss
    morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    e98f2ca View commit details
    Browse the repository at this point in the history

  18. Fix includes

    @morsssss
    morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    a6a161f View commit details
    Browse the repository at this point in the history

  19. Fix IMAGETYPE_AVIF support 

    We fix an accidental fall through, and the order of enum values (COUNT
has to be last).  We also fix the respective test case.
    @cmb69 @morsssss
    cmb69 authored and morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    5e45a76 View commit details
    Browse the repository at this point in the history

  20. Remove AVIF tests from travis and azure; add to cirrus

    @morsssss
    morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    270c6af View commit details
    Browse the repository at this point in the history

  21. Remove avif from a few more spots in test configs

    @morsssss
    morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    31c8c66 View commit details
    Browse the repository at this point in the history

  22. Add imagecreatefromavif config

    @morsssss
    morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    8af2262 View commit details
    Browse the repository at this point in the history

  23. Removed libavif-dev package from azure

    @morsssss
    morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    1c7ef5e View commit details
    Browse the repository at this point in the history

  24. Install libavif in freebsd

    @morsssss
    morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    76f3a98 View commit details
    Browse the repository at this point in the history

  25. Removed conflict resolution crud from rebase

    @morsssss
    morsssss committed May 24, 2021
    Configuration menu
    Copy the full SHA
    370f177 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. Use avif memory allocators 

    Using avifAlloc() here means that libavif has a chance to also free this memory block, which it does in places like avifIOMemoryReaderDestroy().
    @morsssss
    morsssss committed May 25, 2021
    Configuration menu
    Copy the full SHA
    2dafbde View commit details
    Browse the repository at this point in the history

  2. Fixes from code review 

    * removed spurious .DS_Store
* fixed broken switch statement
* fixed indent
    @morsssss
    morsssss committed May 25, 2021
    Configuration menu
    Copy the full SHA
    5da6a4a View commit details
    Browse the repository at this point in the history

  3. Make this work with libavif 0.8.2 

    Propagate change made in libavif a while ago, but which didn't get into this file originally...
    @morsssss
    morsssss committed May 25, 2021
    Configuration menu
    Copy the full SHA
    13e211a View commit details
    Browse the repository at this point in the history

Commits on May 26, 2021

  1. Include image-to-image test 

    New test writes AVIF image losslessly, reads that back in, and compares that to the original
    @morsssss
    morsssss committed May 26, 2021
    Configuration menu
    Copy the full SHA
    1e1cb57 View commit details
    Browse the repository at this point in the history

  2. Newline between test output and expected output

    @morsssss
    morsssss committed May 26, 2021
    Configuration menu
    Copy the full SHA
    9f67adb View commit details
    Browse the repository at this point in the history

  3. Use gd_error() instead of zend_error() 

    Our goal is to have fewer differences from libgd.
The change here I'm introducing in error levels in one case is something I now want to put into libgd.
    @morsssss
    morsssss committed May 26, 2021
    Configuration menu
    Copy the full SHA
    b4c869c View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2021

  1. Merge branch 'master' into avif

    @morsssss
    morsssss authored Jun 2, 2021
    Configuration menu
    Copy the full SHA
    31efece View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2021

  1. Restore libavif, lost during merge 

    Co-authored-by: Nikita Popov <nikita.ppv@googlemail.com>
    @morsssss @nikic
    morsssss and nikic authored Jun 3, 2021
    Configuration menu
    Copy the full SHA
    e8770a5 View commit details
    Browse the repository at this point in the history

  2. Revert changes to ext/standard files 

    These will be included in PR php#7091 instead.
    @morsssss
    morsssss committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    41aedcf View commit details
    Browse the repository at this point in the history

  3. Revert AVIF from image type tests 

    This will be covered in php#7091 .
    @morsssss
    morsssss committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    b0959ab View commit details
    Browse the repository at this point in the history

  4. Removed AVIF from tests properly, this time, I hope

    @morsssss
    morsssss committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    ebe74df View commit details
    Browse the repository at this point in the history

  5. restore https in license URL 

    a horrible artifact of merging
    @morsssss
    morsssss committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    971812e View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2021

  1. Removed spurious spaces

    @morsssss
    morsssss committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    d6603a9 View commit details
    Browse the repository at this point in the history