Fix error handling #472
Merged
Fix error handling #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a custom "addError" Method on the parser context, that was writing string errors into an array and is never queried except in one unit tests. I replaced it with the LoggerInterface. In doing so I had to create the Gridtablebuilder with DI as well, it had been created with a constructor until now. In doing so I also found 4 failing functional tests where errors have been swallowed until now and will address them next
This was causing a silently swallowed error
They are not supported yet
We didnt catch it due to the silentified test
It has been thrown silenced errors since a while
jaapio
approved these changes
Jul 6, 2023
linawolf
added a commit
to linawolf/guides
that referenced
this pull request
Jul 7, 2023
When switching to the logger for error handling in phpDocumentor#472 these tests turned risky as logger->hasError returns a boolean that was not asserted until now
Merged
phpdoc-bot
pushed a commit
to phpDocumentor/guides-restructured-text
that referenced
this pull request
Jul 7, 2023
When switching to the logger for error handling in phpDocumentor/guides#472 these tests turned risky as logger->hasError returns a boolean that was not asserted until now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a custom "addError" Method on the parser context, that was writing string errors into an array and is never queried except in one unit tests. I replaced it with the LoggerInterface. In doing so I had to create the Gridtablebuilder with DI as well, it had been created with a constructor until now.
In doing so I also found 4 failing functional tests where errors have been swallowed until now. I addressed them in seperate commits within this pull request