New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create script to automatically issue PR against https://github.com/josegonzalez/homebrew-php/blob/master/Formula/phpdocumentor.rb on update #909

Closed
mvriel opened this Issue Jun 30, 2013 · 8 comments

Comments

Projects
None yet
3 participants
@mvriel
Member

mvriel commented Jun 30, 2013

At https://github.com/josegonzalez/homebrew-php/blob/master/Formula/phpdocumentor.rb there is a SHA1 hash and version number that needs to be updated everytime we release a new phar. This should be automated as part of the release process.

See Homebrew/homebrew-php#589 (comment) for context

@josegonzalez

This comment has been minimized.

josegonzalez commented Jul 1, 2013

Might help if you don't delete old versions?

@mvriel

This comment has been minimized.

Member

mvriel commented Jul 2, 2013

We replace the existing phpDocumentor.phar with the latest version so that it is clear to developers where to get the latest version; if you have suggestions how to do this and help homebrew then I am all ears!

@josegonzalez

This comment has been minimized.

josegonzalez commented Jul 2, 2013

How about you also create a tagged version somewhere?

# Always points to the latest
phpdocumentor.org/archives/latest.tar.gz

# Always available in archives
phpdocumentor.org/archives/2.5.33.tar.gz

Homebrew-php would peg to a versioned tar, and whenever you release a new version, just have your release script make an issue on my repo with the new sha and version number. I can taker care of the rest from there :)

@josegonzalez

This comment has been minimized.

josegonzalez commented Jul 3, 2013

@mvriel does that sound like a plan?

@mvriel

This comment has been minimized.

Member

mvriel commented Jul 3, 2013

@josegonzalez sounds like a plan to me!

@salamanders

This comment has been minimized.

salamanders commented Oct 15, 2013

A good plan. PS: It is back again, at Homebrew/homebrew-php#589 (who said to yell at you instead of him. Does a "pretty please" request count as yelling? :)

@josegonzalez

This comment has been minimized.

josegonzalez commented Oct 15, 2013

Please stop updating an existing phar file on the interwebs. Much appreciated!

@mvriel

This comment has been minimized.

Member

mvriel commented Dec 5, 2013

@josegonzalez I have separated the process; the phpDocumentor.phar in the root is still updated but a second phar file is uploaded to, for instance, http://phpdoc.org/get/phpDocumentor-2.2.0.phar. When the homebrew recipe refers to that version it should no longer break.

I am going to close this issue for now as I will be doing these updates manually for the time being

@mvriel mvriel closed this Dec 5, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment