[FEATURE] Add and import the database schema #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michield Should we use the SQL as taken from the dump (with the same formatting), or would you prefer it to be autoformatted it (so it is better readable=? |
oliverklee
force-pushed
the
feature/db-schema
branch
2 times, most recently
from
f731779 to
cb6767a
Compare
oliverklee
force-pushed
the
feature/db-schema
branch
from
cb6767a to
2582239
Compare
|
The purpose of the SQL file is primarily for CI testing so in my view the dump is fine. phpList 3 contains the DB structure in array format in structure.php, and it is already planned to add SQL comments to the tables there for contextual documentation. After that is done, the re-dumped SQL here will have comments describing table purpose which will make it more informative. |
samtuke
approved these changes
Jun 22, 2017
|
Please wait for Michiel's review also |
oliverklee
force-pushed
the
feature/db-schema
branch
from
2582239 to
95325c3
Compare
Now Travis import the database schema before each build. The database schema has been taken from the development demo database (but without the data).
oliverklee
force-pushed
the
feature/db-schema
branch
from
95325c3 to
3f764f7
Compare
|
This blocks the next coming PR. @michield Do you have time to take a look at this PR? |
|
I will merge this in the mean time; it can easily be replaced with another dataset in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now Travis import the database schema before each build.
The database schema has been taken from the development demo database
(but without the data).