[FEATURE] System configuration from modules #203
Conversation
oliverklee
force-pushed
the
feature/module-system-configuration
branch
from
c8abaa0
to
f4a8235
Compare
| @@ -137,6 +137,24 @@ the `extra` section of the module's `composer.json` like this: | |||
| } | |||
| ```` | |||
|
|
|||
| You can also provide system configuration for your module: | |||
There was a problem hiding this comment.
This example may be confusing because it relates to the core phpList 4 module, rather than an optional or third part module (even though they are technically managed in the same way). Maybe an example of a hypothetical third party module would be better to make it appear more immediately relevant? Or configuration of the optional REST API module.
There was a problem hiding this comment.
@samtuke I've moved the section that explains that the key always needs to be phplist/phplist4-core. Does this help?
oliverklee
force-pushed
the
feature/module-system-configuration
branch
2 times, most recently
from
1eb4e00
to
785e89b
Compare
|
After either this PR or #205 has been merged, I'll need update the rest-api and base-distribution packages before the other PR can be merged. Otherwise, we'll have at least the rest-api in a state where we would need to change two separate things in one PR (which I generally try to avoid) to get the build green again. |
|
This is blocked until the rest-api PR is merged. |
oliverklee
force-pushed
the
feature/module-system-configuration
branch
2 times, most recently
from
a317b61
to
8337467
Compare
This change is a prerequisite for switching the rest/api module to the FOSRestBundle bundle.
oliverklee
force-pushed
the
feature/module-system-configuration
branch
from
8337467
to
ea177c0
Compare
|
The rest-api changes are merged. Merging this one. |
This change is a prerequisite for switching the rest/api module to the
FOSRestBundle bundle.