Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling unordered baseline violations with ignore line numbers option #430

Merged
merged 3 commits into from
May 3, 2024
Merged

Fix handling unordered baseline violations with ignore line numbers option #430

merged 3 commits into from
May 3, 2024

Conversation

marmichalski
Copy link
Contributor

@marmichalski marmichalski commented May 1, 2024 •
edited
Loading

Handles unordered baseline violations when ignoring baseline numbers.
This resolves #428.

@AlessandroMinoccheri
Copy link
Member

Hi @marmichalski, thank you for this PR.
Can you please fix the Coding Standard errors?

@AlessandroMinoccheri AlessandroMinoccheri added the bug Something isn't working label May 3, 2024
@marmichalski marmichalski changed the title Attempt to fix #428 Fix handling unordered baseline violations with ignore line numbers option May 3, 2024
@AlessandroMinoccheri AlessandroMinoccheri self-assigned this May 3, 2024
@AlessandroMinoccheri
Copy link
Member

@marmichalski Can you please add in the README file this new input --ignore-baseline-linenumbers?

Thank you :)

@marmichalski
Copy link
Contributor Author

@marmichalski Can you please add in the README file this new input --ignore-baseline-linenumbers?

Thank you :)

This one https://github.com/phparkitect/arkitect/blob/81711757459e2130a587e8eaca7da8b8e606ec37/README.md#line-numbers-in-baseline ?

@AlessandroMinoccheri
Copy link
Member

Oh right @marmichalski, forget about my question.
In my opinion the PR LGTM!

Thanks for your contribution!

@AlessandroMinoccheri AlessandroMinoccheri merged commit 5ff8a2d into phparkitect:main May 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlessandroMinoccheri AlessandroMinoccheri AlessandroMinoccheri approved these changes

Assignees

@AlessandroMinoccheri AlessandroMinoccheri

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Baseline with ignorelines not fully working
2 participants
@marmichalski @AlessandroMinoccheri