[ticket/10929] Integration of Plupload #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a highly-refactored and up-to-date version of Fyorl's work which was part of his Google Summer of Code 2012 project "Attachment Improvements". PHPBB3-10929
|
I merged this one and deps into a test branch, but get this error: InformationNo route found for "GET /assets/javascript/plupload.js" which does not exist |
|
Also subSilver2 Changes should be added? |
|
Added the missing file. I am not going to do subsilver2 integration and I don't think that is necessary for alpha1. |
naderman
added a commit
that referenced
this pull request
Oct 13, 2013
[ticket/10929] Integration of Plupload
| mkdir($this->temporary_directory); | ||
|
|
||
| copy( | ||
| $this->upload_directory . '/index.htm', |
There was a problem hiding this comment.
A little bit late, but i think not everyone has this file. Better is to write a new file to the temp_dir.
Also here normaly in phpbb:
@mkdir($dir, 0777);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a highly-refactored and up-to-date version of Fyorl's work which was part of his Google Summer of Code 2012 project "Attachment Improvements".
Requires #1581
Suggests #1582
http://tracker.phpbb.com/browse/PHPBB3-10929