Mejoras a código, excepciones y documentación (versión 0.1.2) #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary curly braces Add braces to dynamic properties compare to empty array instead of compare to count Use named arguments to avoid default arguments Avoid unnecessary cast Remove unnecessary spread operator
- Add phpdoc @throws annotations - All exceptions implements CsfScraperException - Refactor PdfToText constructor, use PdfToText::discoverPathToPdfToText to detect pdftotext executale
celli33
approved these changes
Jun 29, 2022
|
Introduje nuevos cambios en 48a53ad en donde se elimina |
celli33
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Método fábrica de
ScraperSe agrega el método para fabricar estáticamente un objeto
Scrapercon la configuración decurladecuada.Lamentablemente, el sitio del SAT utiliza un esquema de seguridad anticuado que requiere configuración especial.
Refactorización de excepciones
Se agrega la excepción
CifDownloadExceptionque se genera cuando no se pudo descargar la página web de datos fiscales.Se agrega
CsfScraperExceptioncomo una interfaz vacía para identificar las excepciones generadas por esta librería.Se agregan las anotaciones
@throwsa los métodos para identificar que generan excepciones.Refactorizaciones
Pequeñas limpiezas de código y a partes específicas:
CsfExtractorpara mejorar su intención.PdfToTextpara que useShellExecal buscar por el ejecutablepdftotext.