Fix for an issue where languages with a dash in the string was not being selected properly #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… scrubber was removing the dash from the locale causing it to not set the language properly. This is not ideal, but a quick hack. This will be cleaned up in v3
… xx is a language/locale, and if one does not exist then default to English.
Reorganized the language array to make it more readable. Refactored the language detection code to set the default language if one is not already set in the settings.php file. Also added logic so that the app can detect the user's browser preferences and display the site accordingly. Created a method that returns a language drop down list. This is better than having multiple static lists in various places. Made the includes for the various language files more solid. It checks to see if the file exists before trying to include it. This should intercept any errors with the include.
mindblender
added a commit
that referenced
this pull request
May 21, 2015
Fix for an issue where languages with a dash in the string was not being selected properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to fixing issue #4, I refactored the dropdown code to make it more modular.
Please review and leave any comments.
Thanks!