Adding QomToSQL1Converter #17
Conversation
This reverts commit a180e9f.
|
are you sure the converter and generator classes can not share code? its just that the SQL2 thingy is quite buggy and when we duplicate that we have two buggy things... your last commit says "(more to come)" - is this ready to be merged? |
|
I could try and see how many methods are still the same, in the generator it won't be much, maybe in the Converter it's more |
|
i don't want to be complicated but i fear that if we merge this we won't look at it too soon and the pain will just grow :-( |
|
No, you're of course right. |
|
I "merged" the 2 generators now (I worked on them anyway). Next task will be the Converter. Should be able to do it tonight |
|
tests added, code shared in QueryConverters as well |
| */ | ||
| protected function convertStaticOperand(QOM\StaticOperandInterface $operand) | ||
| { | ||
| if ($operand instanceof QOM\BindVariableValueInterface) |
|
and yes i know .. some of the CS violations where there before the refactoring. |
|
hehe, no problem. Thanks for the feedback, will clean it up tomorrow or over the weekend. Too tired right now ;) |
|
cs issues should be fixed |
|
wow. thanks |
|
great, thanks a lot! |
This adds a generic Qom to SQL1 Convertor like the SQL2 one to be used in jackalope-jackrabbit for letting the the QOM decide which SQL engine should be used
See also:
jackalope/jackalope#115
jackalope/jackalope-jackrabbit#17