Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade MSRV and dependencies #157

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Upgrade MSRV and dependencies #157

merged 2 commits into from
Aug 5, 2024

Conversation

jmjoy
Copy link
Member

@jmjoy jmjoy commented Aug 5, 2024

Previous MSRV 1.65 is too old, I think 1.79 is a good choice, because: https://packages.debian.org/trixie/rustc

Xuanwo
Xuanwo approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@Xuanwo Xuanwo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! I can help fix the CI issues.

@jmjoy jmjoy merged commit 212d08c into phper-framework:master Aug 5, 2024
20 checks passed
@jmjoy jmjoy deleted the upgrade branch August 5, 2024 06:54
@jmjoy jmjoy mentioned this pull request Aug 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmjoy @Xuanwo