Fixed variable scoping issue which can lead to out of memory error. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddeboer
added a commit
that referenced
this pull request
Jun 13, 2014
Fixed variable scoping issue which can lead to out of memory error.
|
I guess the problem was that the |
|
Yup, I'm seeing that as well. It looks like it's a bug in the PHP SOAP library. https://bugs.php.net/bug.php?id=45404
|
|
@ddeboer any chance you are going to merge this soon? |
|
This PR is already merged. Can you open a new one? |
|
Ah disregard that comment - I misread @shaunhardy comment. Having the issue he is talking about in #11 . will follow up on that ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$propertiesvariable I'm assuming was expected to go out of scope, however it does not. Each iteration through the SOAP types appends more elements to the$propertiesarray without clearing the data from the previous iteration, leading to massive memory consumption and Out of Memory errors in some cases. I added an explicit reassignment to the$propertiesvariable.In my specific case, this consumed 171MB, and has been reduced to 2MB.