Support nikic/php-parser:^4 #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to use nicik/php-parser:^4 while supporting php < 7.
Node names are not strings anymore (but can be casted to)
|
@tarlepp Can you test this? Metrics should be nearly the same now. Differences are coming from the pretty printer which is used to determine the length of a file. |
UFOMelkor
changed the title
3 tasks
|
I confirm the same results with
|
|
@UFOMelkor oh sorry haven't had the time to test this :( but according to @zdenekdrahos test it seems to work as expected |
Bug fix for php >= 7.2 has been included in 1.2.3. Since phpunit/phpunit ships with ~1.2.2 we does not need an upper boundary.
UFOMelkor
force-pushed
the
feature/345-php-parser-4
branch
from
3271796
to
a3076e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #345
Upgrade-Guide for php-parser can be found here.