Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GPG keyservers #341

Merged
merged 2 commits into from
Aug 12, 2021
Merged

Conversation

PhrozenByte
Copy link
Contributor

sks-keyservers.net was shut down some time ago, see https://sks-keyservers.net/ (expired cert). keys.gnupg.net is just an alias. pgp.mit.edu isn't part of the sks-keyservers.net pool, but also runs SKS and will likely suffer the same fate (like any other SKS keyserver). It is currently unavailable, but there was no take-down notice (yet). The same is true for keys.openpgp.org. I didn't remove those because we should assume that they are unavailable just temporarily. Use keys.openpgp.org as main alternative.

sks-keyservers.net was shut down some time ago. keys.gnupg.net is just
an alias. Neither pgp.mit.edu, nor keyserver.pgp.com are available
right now, but there was no take-down notice, so we should assume they
are temporarily unavailable. Use keys.openpgp.org as main alternative.

Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@williamdes
Copy link
Member

Probably fixes #339

@PhrozenByte
Copy link
Contributor Author

Looks like there are still some issues, it worked locally, failed on one of my servers and passed just 1/3 on GitHub Actions. Will investigate. Not ready for merge yet!

@williamdes williamdes marked this pull request as draft August 11, 2021 17:22
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
@PhrozenByte PhrozenByte marked this pull request as ready for review August 11, 2021 18:30
@PhrozenByte
Copy link
Contributor Author

Okay, looks like this is related to https://dev.gnupg.org/T4393, also see https://keys.openpgp.org/about/faq#older-gnupg (even though I'm no PGP expert). Thus keys.openpgp.org isn't suitable as main alternative. We might wanna use keyserver.ubuntu.com instead - even though it might suffer the same fate as SKS at some time... Hopefully this gets fixed till then.

Updated the PR accordingly, now succeeds both locally and on my server. GitHub Actions pass, too. Ready for merge now.

@williamdes
Copy link
Member

Thank you so much @PhrozenByte

@williamdes williamdes self-assigned this Aug 12, 2021
@williamdes williamdes merged commit 3dafd12 into phpmyadmin:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants