Authentication API cleanup #13764
Merged
Authentication API cleanup #13764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Čihař <michal@cihar.com>
It really does not return in the end, so make the docs consistent with the code. Signed-off-by: Michal Čihař <michal@cihar.com>
Make the API more consistent, remove not needed auth prefix and stop talking about advanced authentication which has been there about 10 years ago. API changed: - authCheck is now readCredentials - authSetUser is now storeCredentials - auth is now showLoginForm - authFails is now showFailure - storeUserCredentials is now rememberCredentials Signed-off-by: Michal Čihař <michal@cihar.com>
Issue #11731 Signed-off-by: Michal Čihař <michal@cihar.com>
Issue #11731 Signed-off-by: Michal Čihař <michal@cihar.com>
Codecov Report
@@ Coverage Diff @@
## master #13764 +/- ##
==========================================
+ Coverage 53.78% 53.87% +0.08%
==========================================
Files 485 485
Lines 82302 82290 -12
==========================================
+ Hits 44268 44333 +65
+ Misses 38034 37957 -77 |
This way we can avoid relying on global variables to check it. Signed-off-by: Michal Čihař <michal@cihar.com>
Use object attributes to store the actual credentials and avoid messing up with global variables. Signed-off-by: Michal Čihař <michal@cihar.com>
Signed-off-by: Michal Čihař <michal@cihar.com>
Signed-off-by: Michal Čihař <michal@cihar.com>
Signed-off-by: Michal Čihař <michal@cihar.com>
Signed-off-by: Michal Čihař <michal@cihar.com>
This can return false and we should fail early once this happens. Signed-off-by: Michal Čihař <michal@cihar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup authentication API, move some helper code from common.inc.php to authentication classes.
Before submitting pull request, please check that every commit: