-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevents return to Browse page. #15675
Conversation
@williamdes @MauricioFauth This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't a function available to build the query string properly? Manually doing string concatenation seems wrong.
Codecov Report
@@ Coverage Diff @@
## master #15675 +/- ##
=========================================
Coverage 52.85% 52.85%
Complexity 14034 14034
=========================================
Files 472 472
Lines 60976 60976
=========================================
Hits 32228 32228
Misses 28748 28748 |
The query string has been built this way in many of the files. I haven't found any function yet but I'll keep looking. |
Fixes phpmyadmin#15662 Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
@OlafvdSpek thanks for pointing it out. I did find the function and have updated the PR. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Active |
Fixes #15662
Signed-off-by: Jayati Shrivastava gaurijove@gmail.com
The Bug - After dropping an index/key the user gets redirected to the Browse page rather than staying on the table structure page.
This has been fixed.
Before submitting pull request, please review the following checklist:
Signed-off-by
line as described in our DCO. This ensures that the work you're submitting is your own creation.