Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents return to Browse page. #15675

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Conversation

victorphoenix3
Copy link
Contributor

@victorphoenix3 victorphoenix3 commented Dec 20, 2019

Fixes #15662

Signed-off-by: Jayati Shrivastava gaurijove@gmail.com

The Bug - After dropping an index/key the user gets redirected to the Browse page rather than staying on the table structure page.

This has been fixed.

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

@victorphoenix3
Copy link
Contributor Author

@williamdes @MauricioFauth This is ready for review.

Copy link

@OlafvdSpek OlafvdSpek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't a function available to build the query string properly? Manually doing string concatenation seems wrong.

@codecov
Copy link

codecov bot commented Dec 20, 2019

Codecov Report

Merging #15675 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #15675   +/-   ##
=========================================
  Coverage     52.85%   52.85%           
  Complexity    14034    14034           
=========================================
  Files           472      472           
  Lines         60976    60976           
=========================================
  Hits          32228    32228           
  Misses        28748    28748

@victorphoenix3
Copy link
Contributor Author

The query string has been built this way in many of the files. I haven't found any function yet but I'll keep looking.

Fixes phpmyadmin#15662

Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
@victorphoenix3
Copy link
Contributor Author

@OlafvdSpek thanks for pointing it out. I did find the function and have updated the PR.

@williamdes williamdes added this to In progress in pull-requests via automation Dec 26, 2019
@stale
Copy link

stale bot commented Feb 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 19, 2020
@victorphoenix3
Copy link
Contributor Author

Active

@stale stale bot removed the wontfix label Feb 19, 2020
pull-requests automation moved this from In progress to Reviewer approved Feb 24, 2020
@williamdes williamdes moved this from Reviewer approved to To merge in pull-requests Feb 24, 2020
@williamdes williamdes self-assigned this Feb 25, 2020
@williamdes williamdes added this to the 5.1.0 milestone Feb 25, 2020
@williamdes williamdes merged commit b5ecd65 into phpmyadmin:master Feb 25, 2020
pull-requests automation moved this from To merge to Done Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
pull-requests
  
Done
Development

Successfully merging this pull request may close these issues.

Returns to browse page after dropping key
4 participants