Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #16935 Remove hardcoded row length #16949

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

shucontech
Copy link
Contributor

Signed-off-by: Saksham Gupta shucontech@gmail.com

Description

Please describe your pull request.

Fixes #16935

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

Signed-off-by: Saksham Gupta <shucontech@gmail.com>

Make changes in default file and docs

Signed-off-by: Saksham Gupta <shucontech@gmail.com>
@codecov
Copy link

codecov bot commented Jun 20, 2021

Codecov Report

Merging #16949 (05587f2) into QA_5_1 (eb96360) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             QA_5_1   #16949   +/-   ##
=========================================
  Coverage     56.51%   56.52%           
+ Complexity    15270    15269    -1     
=========================================
  Files           471      471           
  Lines         62070    62076    +6     
=========================================
+ Hits          35081    35088    +7     
+ Misses        26989    26988    -1     
Flag Coverage Δ
arch-7-amd64 59.88% <100.00%> (+<0.01%) ⬆️
arch-7-arm32v6 59.76% <100.00%> (+<0.01%) ⬆️
arch-7-arm32v7 59.76% <100.00%> (+<0.01%) ⬆️
arch-7-arm64v8 59.88% <100.00%> (+<0.01%) ⬆️
arch-7-i386 59.76% <100.00%> (+<0.01%) ⬆️
arch-7-ppc64le 59.88% <100.00%> (+<0.01%) ⬆️
arch-7-s390x 59.74% <100.00%> (+<0.01%) ⬆️
dbase-extension 56.10% <100.00%> (+<0.01%) ⬆️
recode-extension 56.06% <100.00%> (+<0.01%) ⬆️
unit-7.1-ubuntu-latest 56.06% <100.00%> (+<0.01%) ⬆️
unit-7.2-ubuntu-latest 56.24% <100.00%> (+<0.01%) ⬆️
unit-7.3-ubuntu-latest 59.89% <100.00%> (+<0.01%) ⬆️
unit-7.4-ubuntu-latest 59.90% <100.00%> (+<0.01%) ⬆️
unit-8.0-ubuntu-latest 60.06% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libraries/classes/InsertEdit.php 87.68% <100.00%> (ø)
libraries/config.default.php 99.53% <100.00%> (ø)
libraries/classes/Transformations.php 62.31% <0.00%> (ø)
libraries/classes/Plugins.php 88.00% <0.00%> (+0.06%) ⬆️
libraries/classes/ThemeManager.php 72.44% <0.00%> (+0.13%) ⬆️
libraries/classes/Theme.php 90.00% <0.00%> (+0.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb96360...05587f2. Read the comment docs.

@williamdes williamdes added this to the 5.1.2 milestone Jun 20, 2021
@williamdes williamdes self-assigned this Jun 21, 2021
@williamdes williamdes removed the request for review from MauricioFauth June 21, 2021 21:36
williamdes added a commit that referenced this pull request Jun 21, 2021
…tareaRows

Ref: #16949
Ref: #16935
Pull-request: #14379

Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes merged commit 6e5432d into phpmyadmin:QA_5_1 Jun 21, 2021
@williamdes
Copy link
Member

I added 0c904d6 onto it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants