Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rector Task #1054

Merged
merged 7 commits into from Nov 25, 2022
Merged

Add Rector Task #1054

merged 7 commits into from Nov 25, 2022

Conversation

alessandroaussems
Copy link
Contributor

Q A
Branch rector
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets

This PR adds a task to run Rector with grumphp

New Task Checklist:

  • Are the dependencies added to the composer.json suggestions?
  • Is the doc/tasks.md file updated?
  • Are the task parameters documented?
  • Is the task registered in the tasks.yml file?
  • Does the task contains phpunit tests?
  • Is the configuration having logical allowed types?
  • Does the task run in the correct context?
  • Is the run() method readable?
  • Is the run() method using the configuration correctly?
  • Are all CI services returning green?

@alessandroaussems
Add Rector Task
49df1fe 
Update docs

Register Task

Fix ansi argument

Make clear-cache true by default

Make no-progress-bar true by default

Remove xdebug option

Add Rector Task
veewee
veewee requested changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@veewee veewee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!
I provided some pointers to make it even more awesome. :)

src/Task/Rector.php Outdated Show resolved Hide resolved
src/Task/Rector.php Outdated Show resolved Hide resolved
src/Task/Rector.php Show resolved Hide resolved
src/Task/Rector.php Outdated Show resolved Hide resolved
src/Task/Rector.php Outdated Show resolved Hide resolved
@alessandroaussems
Copy link
Contributor Author

@veewee I processed & answered your remarks!

veewee
veewee approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@veewee veewee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@veewee veewee added this to the 1.15.0 milestone Nov 25, 2022
@veewee veewee merged commit 2b327ae into phpro:master Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veewee veewee veewee approved these changes

Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alessandroaussems @veewee