Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PHPCS specific rule (-s) to display which rule triggered the e… #1059

Merged

Conversation

MeCapron
Copy link
Contributor

Summary

Q A
Branch master for features and deprecations
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets comma-separated list of tickets fixed by the PR, if any

This PR adds the -s which displays the rule that triggered the error when running phpcs.

As an example :

image

Configuration

The configuration is set to true by default so that developers can more easily find the rule that blocks the validation of phpcs.

As s was not clear enough, the rule was renamed to show_sniffs_error_path inside grumphp configuration.

Reference

The reference of the phpcs configuration can be found here : https://github.com/squizlabs/PHP_CodeSniffer/wiki/Reporting#printing-full-and-summary-reports

@veewee veewee added this to the 1.15.0 milestone Dec 17, 2022
@veewee veewee merged commit f41ca33 into phpro:master Dec 17, 2022
@veewee
Copy link
Contributor

veewee commented Dec 17, 2022

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants