Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply str_contains to replace the strpos usage #1112

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Apply str_contains to replace the strpos usage #1112

merged 1 commit into from
Oct 3, 2023

Conversation

peter279k
Copy link
Contributor

@peter279k peter279k commented Oct 3, 2023 •
edited
Loading

Q A
Branch v2.x
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Documented? no
Fixed tickets comma-separated list of tickets fixed by the PR, if any

Apply using the str_contains function to replace the strpos function usage.

New Task Checklist:

  • Are the dependencies added to the composer.json suggestions?
  • Is the doc/tasks.md file updated?
  • Are the task parameters documented?
  • Is the task registered in the tasks.yml file?
  • Does the task contains phpunit tests?
  • Is the configuration having logical allowed types?
  • Does the task run in the correct context?
  • Is the run() method readable?
  • Is the run() method using the configuration correctly?
  • Are all CI services returning green?

@veewee veewee added this to the 2.2.0 milestone Oct 3, 2023
@veewee veewee merged commit da1d97b into phpro:v2.x Oct 3, 2023
10 checks passed
@veewee
Copy link
Contributor

veewee commented Oct 3, 2023

Thanks

@peter279k peter279k deleted the apply_str_contains branch October 3, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@peter279k @veewee