Ensure export command does not run if authentication process fails #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would be closing this PR now based on our latest decision to limit exporting notebooks to only registered users. |
bosunski
reviewed
Jul 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Ensure export command does not run if authentication process fails, limit export to only authenticated users.
Why did you want to accomplish this?
Currently, when a user attempts to export, he would be asked if he wants to export as a guest user or as an authenticated user. If he decides to export as an authenticated user, the login command is called . If the user is not successfully logged in, the export still continues however it treats the user as a guest. This PR stops the whole export process if such scenario occurs so users wont think they are authenticated while they actually are not.
How did you accomplish this?
Ensure the login command returns an exit code which is used to check if it run successfully in the export command.
Move the check for authenticated user into a task in the multitask function
What could go wrong?
none
ToDos