Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit 10 compatibility, master is compatible but not the v1.17.0 tag… #599

Closed
shulard opened this issue Jun 20, 2023 · 7 comments
Closed

Comments

@shulard
Copy link

shulard commented Jun 20, 2023

Hello !

I work on a project where we are using both PHPUnit and PHPSpec. I can't upgrade to PHPUnit 10 because there is a conflict with the latest stable version of phpspec/prophecy which requires sebastian/recursion-context v4.

I viewed that the master branch is up to date and allows installing PHPUnit 10, do you think it might be possible to create a new release ? Is there some instability today on master that might block the release process ?

If so I can try to help fixing those issues… Let me know 😄

@alexander-schranz
Copy link
Contributor

alexander-schranz commented Jul 25, 2023

Not a maintainer of this project but think at current case the best until it is released is what we can do, is to test if the current master versions works as expected by trying it out in our projects and give feedback if we stumble over some issues. For this you can currently use the @dev versions:

    "require-dev": {
        "phpspec/prophecy": "^1.18@dev",
        "phpspec/prophecy-phpunit": "^2.1@dev",
        "phpunit/phpunit": "^10.2"
    }

For paratest user also update to:

        "brianium/paratest": "^7.0",

is required. In my case with a project about ~1800 Unit Tests using prophecy all did work fine.

@keradus
Copy link

keradus commented Oct 6, 2023

@stof , I think it was you releasing last time. You think a new release of what is already merged is possible?

@rikgirbes
Copy link

Any updates on this? I really dislike using @dev's in my composer.json...

@jg-development
Copy link

+1

@jorgsowa
Copy link

Hello @stof. Do you need any help releasing a new version?

@stof
Copy link
Member

stof commented Dec 7, 2023

1.18.0 has been released now

@stof stof closed this as completed Dec 7, 2023
@keradus
Copy link

keradus commented Dec 7, 2023

thanks @stof !

Unfortunately, I failed to install it because this one is not yet compatible (yet having v10 PR already merged, simply not released):
https://github.com/phpspec/prophecy-phpunit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants