Fix internal error in SimpleXMLElementConstructorThrowTypeExtension

phpstan · Aug 5, 2023 · 4f6b051 · 4f6b051
1 parent a5e5719
commit 4f6b051
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/Type/Php/SimpleXMLElementConstructorThrowTypeExtension.php b/src/Type/Php/SimpleXMLElementConstructorThrowTypeExtension.php
@@ -11,13 +11,16 @@
 use PHPStan\Type\TypeCombinator;
 use SimpleXMLElement;
 use function count;
+use function extension_loaded;
 
 class SimpleXMLElementConstructorThrowTypeExtension implements DynamicStaticMethodThrowTypeExtension
 {
 
 	public function isStaticMethodSupported(MethodReflection $methodReflection): bool
 	{
-		return $methodReflection->getName() === '__construct' && $methodReflection->getDeclaringClass()->getName() === SimpleXMLElement::class;
+		return extension_loaded('simplexml')
+			&& $methodReflection->getName() === '__construct'
+			&& $methodReflection->getDeclaringClass()->getName() === SimpleXMLElement::class;
 	}
 
 	public function getThrowTypeFromStaticMethodCall(MethodReflection $methodReflection, StaticCall $methodCall, Scope $scope): ?Type

diff --git a/src/Type/Php/SimpleXMLElementXpathMethodReturnTypeExtension.php b/src/Type/Php/SimpleXMLElementXpathMethodReturnTypeExtension.php
@@ -13,6 +13,7 @@
 use PHPStan\Type\Type;
 use PHPStan\Type\TypeCombinator;
 use SimpleXMLElement;
+use function extension_loaded;
 
 class SimpleXMLElementXpathMethodReturnTypeExtension implements DynamicMethodReturnTypeExtension
 {
@@ -24,7 +25,7 @@ public function getClass(): string
 
 	public function isMethodSupported(MethodReflection $methodReflection): bool
 	{
-		return $methodReflection->getName() === 'xpath';
+		return extension_loaded('simplexml') && $methodReflection->getName() === 'xpath';
 	}
 
 	public function getTypeFromMethodCall(MethodReflection $methodReflection, MethodCall $methodCall, Scope $scope): Type