Allow numbers in error identifiers

phpstan · Jul 17, 2023 · ba374e4 · ba374e4
1 parent 9882693
commit ba374e4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/Analyser/Error.php b/src/Analyser/Error.php
@@ -276,7 +276,7 @@ public static function __set_state(array $properties): self
 
 	public static function validateIdentifier(string $identifier): bool
 	{
-		return Strings::match($identifier, '~^[a-zA-Z]([a-zA-Z\\.]*[a-zA-Z])?$~') !== null;
+		return Strings::match($identifier, '~^[a-zA-Z0-9]([a-zA-Z0-9\\.]*[a-zA-Z0-9])?$~') !== null;
 	}
 
 }
diff --git a/tests/PHPStan/Analyser/ErrorTest.php b/tests/PHPStan/Analyser/ErrorTest.php
@@ -24,6 +24,9 @@ public function dataValidIdentifier(): iterable
 		yield ['phpstan.alwaysFail'];
 		yield ['Phpstan.alwaysFail'];
 		yield ['phpstan.internal.foo'];
+		yield ['foo2.test'];
+		yield ['phpstan123'];
+		yield ['3m.blah'];
 	}
 
 	/**
@@ -38,7 +41,6 @@ public function dataInvalidIdentifier(): iterable
 	{
 		yield [''];
 		yield [' '];
-		yield ['phpstan123'];
 		yield ['phpstan '];
 		yield [' phpstan'];
 		yield ['.phpstan'];