Fix finfo constructor

phpstan · Jun 8, 2020 · c2135cb · c2135cb
1 parent 61f7a97
commit c2135cb
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/src/Reflection/SignatureMap/functionMap.php b/src/Reflection/SignatureMap/functionMap.php
@@ -2983,6 +2983,7 @@
 'FilterIterator::rewind' => ['void'],
 'FilterIterator::valid' => ['bool'],
 'finfo::__construct' => ['void', 'options='=>'int', 'magic_file='=>'string'],
+'finfo::finfo' => ['void', 'options='=>'int', 'magic_file='=>'string'],
 'finfo::buffer' => ['string|false', 'string'=>'string', 'options='=>'int', 'context='=>'resource'],
 'finfo::file' => ['string|false', 'file_name'=>'string', 'options='=>'int', 'context='=>'resource'],
 'finfo::set_flags' => ['bool', 'options'=>'int'],

diff --git a/tests/PHPStan/Rules/Classes/InstantiationRuleTest.php b/tests/PHPStan/Rules/Classes/InstantiationRuleTest.php
@@ -208,4 +208,14 @@ public function testClassExists(): void
 		$this->analyse([__DIR__ . '/data/instantiation-class-exists.php'], []);
 	}
 
+	public function testBug3404(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-3404.php'], [
+			[
+				'Class finfo constructor invoked with 3 parameters, 0-2 required.',
+				7,
+			],
+		]);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Classes/data/bug-3404.php b/tests/PHPStan/Rules/Classes/data/bug-3404.php
@@ -0,0 +1,7 @@
+<?php
+
+namespace Bug3404;
+
+new \finfo();
+new \finfo(FILEINFO_MIME_TYPE);
+new \finfo(0, 'foo', 'bar');