Rework

Author: VincentLanglet

src/PhpDoc/ResolvedPhpDocBlock.php

@@ -252,10 +252,7 @@ public static function createEmpty(): self
 	 */
 	public function merge(array $parents, array $parentPhpDocBlocks): self
 	{
-		$className = $this->nameScope !== null ? $this->nameScope->getClassName() : null;
-		$classReflection = $className !== null && $this->reflectionProvider->hasClass($className)
-			? $this->reflectionProvider->getClass($className)
-			: null;
+		$classReflection = $this->getClassReflection();
 
 		// new property also needs to be added to createEmpty()
 		$result = new self();
@@ -461,6 +458,20 @@ public function getNullableNameScope(): ?NameScope
 		return $this->nameScope;
 	}
 
+	private function getClassReflection(): ?ClassReflection
+	{
+		if ($this->nameScope === null) {
+			return null;
+		}
+
+		$className = $this->nameScope->getClassName();
+		if (!$this->reflectionProvider->hasClass($className)) {
+			return null;
+		}
+
+		return $this->reflectionProvider->getClass($className);
+	}
+
 	/**
 	 * @return array<(string|int), VarTag>
 	 */
@@ -827,6 +838,14 @@ public function isPure(): ?bool
 				return $this->isPure;
 			}
 
+			if ($this->nameScope !== null) {
+				$classReflection = $this->getClassReflection();
+				if ($classReflection !== null) {
+					$this->isPure = $classReflection->getDefaultMethodPurity();
+					return $this->isPure;
+				}
+			}
+
 			$this->isPure = null;
 		}
 

src/Reflection/Php/PhpClassReflectionExtension.php

@@ -892,7 +892,7 @@ public function createUserlandMethodReflection(ClassReflection $fileDeclaringCla
 			}
 		}
 
-		$isPure ??= $resolvedPhpDoc->isPure() ?? $phpDocBlockClassReflection->getDefaultMethodPurity();
+		$isPure ??= $resolvedPhpDoc->isPure();
 		$asserts = Assertions::createFromResolvedPhpDocBlock($resolvedPhpDoc);
 		$acceptsNamedArguments = $resolvedPhpDoc->acceptsNamedArguments();
 		$selfOutType = $resolvedPhpDoc->getSelfOutTag() !== null ? $resolvedPhpDoc->getSelfOutTag()->getType() : null;