bleeding edge only

Author: staabm

conf/bleedingEdge.neon

@@ -13,3 +13,4 @@ parameters:
 		reportTooWideBool: true
 		rawMessageInBaseline: true
 		reportNestedTooWideType: false
+		curlSetOptArrayTypes: true

conf/config.neon

@@ -37,6 +37,7 @@ parameters:
 		reportTooWideBool: false
 		rawMessageInBaseline: false
 		reportNestedTooWideType: false
+		curlSetOptArrayTypes: false
 	fileExtensions:
 		- php
 	checkAdvancedIsset: false

conf/parametersSchema.neon

@@ -40,6 +40,7 @@ parametersSchema:
 		reportTooWideBool: bool()
 		rawMessageInBaseline: bool()
 		reportNestedTooWideType: bool()
+		curlSetOptArrayTypes: bool()
 	])
 	fileExtensions: listOf(string())
 	checkAdvancedIsset: bool()

src/Reflection/ParametersAcceptorSelector.php

@@ -27,7 +27,6 @@
 use PHPStan\Type\ArrayType;
 use PHPStan\Type\BooleanType;
 use PHPStan\Type\CallableType;
-use PHPStan\Type\Constant\ConstantArrayType;
 use PHPStan\Type\Constant\ConstantArrayTypeBuilder;
 use PHPStan\Type\Constant\ConstantIntegerType;
 use PHPStan\Type\Generic\TemplateType;
@@ -53,6 +52,7 @@
 use function constant;
 use function count;
 use function defined;
+use function is_int;
 use function is_string;
 use function sprintf;
 use const ARRAY_FILTER_USE_BOTH;
@@ -163,7 +163,7 @@ public static function selectFromArgs(
 				$optArrayType = $scope->getType($args[1]->value);
 
 				$builder = ConstantArrayTypeBuilder::createEmpty();
-				foreach($optArrayType->getIterableKeyType()->getConstantScalarValues() as $optValue) {
+				foreach ($optArrayType->getIterableKeyType()->getConstantScalarValues() as $optValue) {
 					if (!is_int($optValue)) {
 						$builder = null;
 						break;
@@ -177,7 +177,7 @@ public static function selectFromArgs(
 
 					$builder->setOffsetValueType(
 						new ConstantIntegerType($optValue),
-						$optValueType
+						$optValueType,
 					);
 				}
 

tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php

@@ -1384,17 +1384,17 @@ public function testCurlSetOptArray(): void
 			[
 				"Parameter #2 \$options of function curl_setopt_array expects array{19913: bool, 10102: string, 68: int, 13: int, 84: int, 10036: non-empty-string|null}, array{19913: true, 10102: '', 68: 10, 13: 30, 84: 2, 10036: CurlSetOptArray\RequestMethod::POST} given.",
 				30,
-				"Offset 10036 (non-empty-string|null) does not accept type CurlSetOptArray\RequestMethod::POST."
+				'Offset 10036 (non-empty-string|null) does not accept type CurlSetOptArray\RequestMethod::POST.',
 			],
 			[
 				"Parameter #2 \$options of function curl_setopt_array expects array{19913: bool, 10102: string, 68: int, 13: int, 84: int, 10036: non-empty-string|null}, array{19913: true, 10102: '', 68: 10, 13: 30, 84: 2, 10036: CurlSetOptArray\BackedRequestMethod::POST} given.",
 				42,
-				"Offset 10036 (non-empty-string|null) does not accept type CurlSetOptArray\BackedRequestMethod::POST."
+				'Offset 10036 (non-empty-string|null) does not accept type CurlSetOptArray\BackedRequestMethod::POST.',
 			],
 			[
 				"Parameter #2 \$options of function curl_setopt_array expects array{19913: bool, 10102: string, 68: int, 13: int, 84: int}, array{19913: '123', 10102: '', 68: 10, 13: 30, 84: false} given.",
 				54,
-				"Offset 19913 (bool) does not accept type string."
+				'Offset 19913 (bool) does not accept type string.',
 			],
 
 		]);