implement MissingMagicSerializationMethodsRule#1711
implement MissingMagicSerializationMethodsRule#1711ondrejmirtes merged 1 commit intophpstan:1.9.xfrom
Conversation
76e3bb0 to
df67c40
Compare
There was a problem hiding this comment.
not sure about the error message... implementing magic serialize actually is only required in case you want to support old-phpversions in tandem.
|
not sure how to fix the phpstan error on 7.2 |
There was a problem hiding this comment.
good question. I just copied it from ;)
phpstan-src/src/Rules/Methods/MissingMethodImplementationRule.php
Lines 36 to 40 in fb08fb5
There was a problem hiding this comment.
Alright ,better to keep it, there's probably a reason.
c4981bd to
32e816b
Compare
|
except the one remaining problem mentioned in #1711 (comment) this should be good to go |
33e5ea0 to
07261df
Compare
inspired by be1ce08 I figured, I should also add this error to the ignore list. I did so with 8680735 |
2206bb4 to
f408e70
Compare
3102945 to
0351619
Compare
0351619 to
54a21f2
Compare
|
Thank you. |
closes phpstan/phpstan#7482
refs phpstan/phpstan#7953