fix returntype for DateIntervall::createFromDateString

[verfriemelt-dot-org]

this should fix phpstan/phpstan#8442
seems to be a simple fix, not sure if i done everything correct.

[staabm]

the snippet from phpstan/phpstan#8442 should be added to this PR as a NodeScopeResolverTest including proper assertType calls

[verfriemelt-dot-org]

i will look into this! 👍

[staabm]

Would be great if you could adjust other similar existing extensions which also miss the getConstantStrings() handling, after this one was merged

[ondrejmirtes]

Also - you have some random spaces in there that I don't like but CS isn't picking up them as errors. Please get rid of them.

Like: if ( count or $strings[0 ].

[ondrejmirtes]

This code will crash if someone has DateInterval::createFromDateString() without an argument in their code.

[verfriemelt-dot-org]

true, fixed that. but it leaves me wondering, what to return when this case is found?

		$arguments = $methodCall->getArgs();

		if (!isset($arguments[0])) {
			return null;
		}

i opted for the default type but running code like this with warnings supressed does not execute at all. so what would be the correct thing to do here?

[verfriemelt-dot-org]

i opted for this:

	assertType('DateInterval|false',DateInterval::createFromDateString());
	assertType('DateInterval|false',DateInterval::createFromDateString(new stdClass()));

[verfriemelt-dot-org]

Also - you have some random spaces in there that I don't like but CS isn't picking up them as errors. Please get rid of them.

Like: if ( count or $strings[0 ].

intresting, make cs-fix will not clean this up 🤔 i fixed them by hand :)

[ondrejmirtes]

Thank you!