Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnnotationsPropertiesClassReflectionExtension: More specific property prevail #2329

Merged

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Apr 5, 2023

Restore the behaviour from before asymmetric properties were introduced, when @property-read and @property-write would shadow @property. This is slightly more intuitive since those tags are more specific.

Another follow-up to #2327

… prevail

Restore the behaviour from before asymmetric properties were introduced,
when `@property-read` and `@property-write` would shadow `@property`.
This is slightly more intuitive since those tags are more specific.
@ondrejmirtes ondrejmirtes merged commit 95a8777 into phpstan:1.10.x Apr 5, 2023
@ondrejmirtes
Copy link
Member

Thank you!

@jtojnar jtojnar deleted the specific-property-tags-prevail branch April 5, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants