fix: incorrect argument type for Redis::setex / Redis::setnx #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taka-oyama
force-pushed
the
fix/redis-set-signatures
branch
from
91caab2
to
b726f64
Compare
|
@ondrejmirtes is there a specific reason to keep both cases? IIRC they are strtolower-ed during the map build |
|
Closing since it seems like it was fixed in #2706. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmit of #2621 to rebase it with 1.10x.
This will change argument type of
$valuefromstringtomixed.This is needed because it's possible to set mixed values in PhpRedis when a serializer is set through
Redis::setOption(...).