Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More concrete return types for some database functions #3078

Merged
merged 1 commit into from
May 15, 2024

Conversation

devnix
Copy link
Contributor

@devnix devnix commented May 15, 2024

I'm not 100% sure about how hard can we trust on this, but I don't find a case where those arrays should ever be empty.

This suggestion is related to doctrine/dbal#6287

@devnix
Copy link
Contributor Author

devnix commented May 15, 2024

I have a couple of questions. Changing the return of SQLite3Result::fetchArray() to a conditional one depending on the mode parameter would be considered a breaking change and should be on bleeding edge? Should we propose all these changes to bleeding edge?

@ondrejmirtes
Copy link
Member

Changing the return

I don't think that's a BC break. It's simply improving the analysis to be more precise.

@ondrejmirtes ondrejmirtes merged commit 16d5b01 into phpstan:1.11.x May 15, 2024
444 of 445 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants