Comparison operation ">" between (int<min, X>|int<Y, max>|string) and Z is always true.

[neanton]

Bug report

The following snippet produces this error:

Comparison operation ">" between (int<min, 4>|int<11, max>|string) and 10 is always true.

Seems like the problem is caused by mixed array key. Type hinting array returned from getValue function to <int, int> suppresses the warning.

Code snippet that reproduces the problem

https://phpstan.org/r/e9007c26-e626-49e5-aa97-469e860ea8ea

Expected output

No error should be thrown

[phpstan-bot]

@neanton After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
- 9: Comparison operation ">" between (int<min, 4>|int<11, max>|string) and 10 is always true.
-18: Method Demo::getValue() return type has no value type specified in iterable type array.
+18: Method Demo::getValue() return type has no value type specified in iterable type array.
+18: Method Demo::getValue() should return array but return statement is missing.

Full report

Line	Error
18	Method Demo::getValue() return type has no value type specified in iterable type array.
18	Method Demo::getValue() should return array but return statement is missing.

[phpstan-bot]

@neanton After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
- 9: Comparison operation ">" between (int<min, 4>|int<11, max>|string) and 10 is always true.
 18: Method Demo::getValue() return type has no value type specified in iterable type array.

Full report

Line	Error
18	Method Demo::getValue() return type has no value type specified in iterable type array.

[ondrejmirtes]

Fixed: phpstan/phpstan-src@dd5633f

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.