False positive: strtotime($date) < time() is always true

[schlndh]

Bug report

It looks like PHPStan is confused about (int|false) < int<1, max>, the fact that it's related to time functions is probably just because of the changes from 1.1.2.

Code snippet that reproduces the problem

https://phpstan.org/r/2096429c-7a1b-438a-9738-2be373692672

Expected output

No errors.

[staabm]

The actual problem is you are passing a mixed to strtotime()

[schlndh]

@staabm Thanks, that explains why it works fine with the typed property. I guess that phpstan is unable to take advantage of is_string in the last case then. Even so, the (int|false) < int<1, max> part remains valid.

[phpstan-bot]

@schlndh After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-11: Comparison operation "<" between (int|false) and int<1, max> is always true.
-16: Comparison operation "<" between (int|false) and int<1, max> is always true.
+No errors

[ondrejmirtes]

Fixed: phpstan/phpstan-src@dd5633f

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.