Property (-1|int<1, max>) does not accept int

[acelaya]

Bug report

I have a property annotated as @var positive-int|-1, but even if I explicitly check that the value to be assigned actually fulfils that (< 0 || === -1), PHPStan keeps reporting it cannot assign int to (-1|int<1, max>).

Code snippet that reproduces the problem

https://phpstan.org/r/22add73c-2fd7-45a1-a5b3-2e1ddb8a1847

Expected output

PHPStan should not throw an error

Did PHPStan help you today? Did it make you happy in any way?

PHPStan always helps. It's just amazing 🙂

[herndlm]

Fyi the base problem seems to be the || that it apparently does not understand, see https://phpstan.org/r/019dca66-148c-483e-8e5c-f62ab1b5834e

[ondrejmirtes]

@herndlm Yes, line 20 in your example should be -1|int<1, max>.

[acelaya]

It still fails https://phpstan.org/r/71a29c1c-0f36-4401-9a07-61d3ed867142

[ondrejmirtes]

Yeah, it's not fixed (I didn't say it is.)

[acelaya]

Oh, sorry, haha.

[phpstan-bot]

@acelaya After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-13: Property HelloWorld::$myValue (-1|int<1, max>) does not accept int.
+No errors

[phpstan-bot]

@herndlm After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
 14: Dumped type: -1
 17: Dumped type: int<1, max>
-20: Dumped type: int
-22: Property HelloWorld::$myValue (-1|int<1, max>) does not accept int.
+20: Dumped type: -1|int<1, max>

Full report

Line	Error
14	Dumped type: -1
17	Dumped type: int<1, max>
20	`Dumped type: -1

[phpstan-bot]

@acelaya After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-13: Property HelloWorld::$myValue (-1|int<1, max>) does not accept int.
+No errors

[ondrejmirtes]

Fixed: phpstan/phpstan-src@68e6443

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.