Parameter $object of method expects T of object, T of object|T of object given.

[VincentLanglet]

Bug report

I'm starting using the 1.0 version and I have a weird issue.

Parameter #1 $object of static method Test::getClass() expects T of object, T of object|T of object given.

Code snippet that reproduces the problem

https://phpstan.org/r/bf359dd0-d44c-4b4d-9916-75e450c344fa

Removing the

if (method_exists($object, '__toString') && null !== $object->__toString()) {
    return $object->__toString();
}

fix the issue.

Expected output

No error

Did PHPStan help you today? Did it make you happy in any way?

Great job for the 1.0

[VincentLanglet]

Friendly ping @ondrejmirtes, any idea where should I look at in the phpstan-src code for this bug ?

[ondrejmirtes]

@VincentLanglet The type in else and after the condition is probably wrong: https://phpstan.org/r/4aa995ef-3e9e-470d-818c-f9954c262e71

Which means this is about what happens in MutatingScope::filterByFalseyValue().

[VincentLanglet]

I have difficulties to debug this, but I discovered that
https://phpstan.org/r/db53ce31-4f9b-4cc6-9b66-16a6ee97bc0f
with method_exists($object, '__toString') && true is not working, but
https://phpstan.org/r/34f86f0e-9fd5-4723-af9d-21ae54e7fa84
with true && method_exists($object, '__toString') is working.

Dunno if it helps

[VincentLanglet]

Seems like this was solved in 1.4.4

[VincentLanglet]

@ondrejmirtes Do you know if it was expected to be solved by a recent PR ?
Does this require a non-regression test or it already has similar one ?

[ondrejmirtes]

Yes, I'll add a regression test.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.