allow php7 #5
Merged
allow php7 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update sdk to 1.7 and use the same php requirements
Closed
Runs it against PHP7 on Travis
|
@phptek bump |
phptek
approved these changes
Jul 10, 2017
| @@ -14,8 +14,8 @@ | |||
| "silverstripe/sentry": "*" | |||
| }, | |||
| "require": { | |||
| "php": ">=5.3.3,<7", | |||
| "sentry/sentry": "1.6.2", | |||
| "php": "^5.3|^7.0", | |||
There was a problem hiding this comment.
The module uses PHP's JavaScript array notation introduced in 5.4. (So the platform req should always have been 5.4, my bad)
I've not seen that pipe syntax before and looking around it either represents bitwise or an older logical OR operator. Did you mean to use that? What's wrong with simply updating the range as before, but specifying 5.4 on the LHS e.g. ">=5.4,<=7.2"? (Note 7.2 is the upper limit of what SS 3.6 will run on)
There was a problem hiding this comment.
sure that make sense, do you need anything from my side?
There was a problem hiding this comment.
Nah, I'll merge it and patch it up when I get a moment. Cheers!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update sdk to 1.7 and use the same php requirements