Skip to content
This repository has been archived by the owner on Mar 29, 2024. It is now read-only.

Revisit valgrind suppressions #49

Closed
pinepain opened this issue Sep 4, 2017 · 2 comments
Closed

Revisit valgrind suppressions #49

pinepain opened this issue Sep 4, 2017 · 2 comments
Assignees
Milestone

Comments

@pinepain
Copy link
Member

pinepain commented Sep 4, 2017

At the moment some valgrind reports which doesn't look like relevant one to project, one which comes from v8 internals and other which happens only in docker, are suppressed (see #47 for details).

Ideally they should be revisited and validated.

@pinepain
Copy link
Member Author

To workaround missed debug info in library (https://bugs.chromium.org/p/chromium/issues/detail?id=603286) we have add more valgrind overrides for the same false-positive reporting.

@pinepain pinepain added bug and removed help wanted labels Jan 1, 2018
@pinepain pinepain self-assigned this Jan 1, 2018
@pinepain pinepain added this to the 0.2.2 milestone Jan 1, 2018
@pinepain
Copy link
Member Author

pinepain commented Jan 1, 2018

It came up that the issue was in how I built libv8: it was built with clang and in general was not build to be relocatable, so the fact that libv8 worked was more a coincidence then by design.

Starting from libv8 6.5.116 I build it with the following GN args:

    is_debug: false,
    is_official_build: true,
    is_component_build: true,
    is_cfi: false,
    is_clang: false,
    v8_use_external_startup_data: false,
    treat_warnings_as_errors: false,
    use_custom_libcxx: false,
    use_sysroot: false,
    use_gold: false

which fits packaging needs much better and for now tests shows that memory issue reports gone.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant