garbage collection in-process #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the old style exec php & thing didn't work for backgrounding processes anyway, so I've moved it in process. still happens after render, so it shouldn't impact users more than it did before. also using a unix find which acts 1 file at a time without listing them all first, so high numbers of files shouldn't crash or use up a lot of memory.
|
hey guys, think this should fix the garbage collection memory issues. won't merge till it's been tested by someone besides me locally just in case. |
|
Sorry, looks like I took too long to review 😂 |
sheldon
commented
Jun 13, 2023
| $stats = stat("$dir/garbage.collect.lock"); | ||
| if($stats && $stats[9] + WaxSession::$garbage_collection_timeout < time()){ | ||
| touch("$dir/garbage.collect.lock"); | ||
| exec("cd $dir && find . -mmin ".(WaxSession::$garbage_collection_timeout / 60)." -exec rm -f \"{}\" \\;"); //mmin is in minutes |
There was a problem hiding this comment.
my plan was to run rm -rf based on an event coming from a render of a request coming in from a remote request. I feel ashamed and very glad it never got merged.
Also, hi Ross! ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the old style exec php & thing didn't work for backgrounding processes
anyway, so I've moved it in process. still happens after render, so it
shouldn't impact users more than it did before. also using a unix find
which acts 1 file at a time without listing them all first, so high
numbers of files shouldn't crash or use up a lot of memory.