This repository has been archived by the owner on May 28, 2023. It is now read-only.
Added image media block spec #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I'll write the specs for the other media blocks if this PR seems all right. |
|
@phuctm97 Could you please review and report? |
|
Hi @Devorein. Love the image spec. For the parent part, could we make a separate issue and discuss it first? |
|
Good idea. I'll leave the parent part and create another commit, it's best to discuss it in another issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added basic description, interface, example, and yield. Furthermore changed
Parentto inherit fromBlockinterface for two reasons:-Parentcould be a child of anotherParent, which would make it aBlock.Parent, just likeBlockshould have a unique id constraint whichUnistParentdoes not enforce.